Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Finder's NewWindowTarget option #206

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Finder's NewWindowTarget option #206

wants to merge 2 commits into from
+66 −0

Conversation

amomchilov
Copy link
Contributor

TODO:

Can somebody please check what values are set when the chosen option is "iCloud Drive" (it's disabled on my machine, so I can't check it myself)

I checked it with:

defaults read com.apple.Finder > before.txt
# Make the change, and try the next line a few times until the setting is persisted:
defaults read com.apple.Finder > after.txt ; git diff before.txt after.txt

rm before.txt after.txt

yannbertrand
yannbertrand reviewed Feb 10, 2022
View reviewed changes
defaults.yml Outdated Show resolved Hide resolved
yannbertrand
yannbertrand reviewed Feb 10, 2022
View reviewed changes
defaults.yml Outdated Show resolved Hide resolved
@amomchilov
Copy link
Contributor Author

I had an indentation error. I've fixed it. Could you retry the CI and merge this if it's good? :)

@amomchilov
Copy link
Contributor Author

Oh, looks like the examples are mandatory. Should they be?

yannbertrand
yannbertrand reviewed Aug 16, 2022
View reviewed changes
defaults.yml Outdated Show resolved Hide resolved
@yannbertrand yannbertrand mentioned this pull request Aug 16, 2022
Open
@yannbertrand
Copy link
Owner

The fact that we need 2 commands to change this settings breaks the architecture of the project which assumed 1 command was always sufficient. I will adapt the project architecture to be able to create these kind of complex commands.

Thanks a lot for this PR anyways, I'll update it to merge when the project is ready.

@yannbertrand yannbertrand force-pushed the main branch 3 times, most recently from a7bc1a8 to 9feedb1 Compare August 18, 2022 09:08
@yannbertrand yannbertrand mentioned this pull request Aug 17, 2023
Merged
@amomchilov
Copy link
Contributor Author

I think commit 2a08b77 got added to this branch by accident. This PR only relates to 9f1b4a8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbertrand yannbertrand yannbertrand left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amomchilov @yannbertrand @thisisommore